switch Z_FEATURE_UNSTABLE_API to #ifdef #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR missing one of the required labels: {'dependencies', 'enhancement', 'bug', 'documentation', 'new feature', 'breaking-change', 'internal'} |
jean-roland
added
enhancement
jean-roland
changed the title
jean-roland
force-pushed
the
ft_unstable
branch
from
be99e58
to
9c7f1c2
Compare
jean-roland
changed the title
DenisBiryukov91
approved these changes
Sep 13, 2024
|
LGTM. Although we should probably also switch to using similar Z_FEATURE_xxx defines in zenoh-c, so I would like to postpone merging till this is resolved. |
jean-roland
force-pushed
the
ft_unstable
branch
from
9c7f1c2
to
05c9d3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #633.